Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bump grafana to 8.5.0 #2592

Closed
wants to merge 16 commits into from
Closed

feat: Bump grafana to 8.5.0 #2592

wants to merge 16 commits into from

Conversation

mesosphere-ci
Copy link
Contributor

Upgrades the following apps to use version 8.5.0 of chart grafana:

  • grafana-logging from version 8.3.5 to 8.5.0
  • project-grafana-logging from version 8.3.4 to 8.5.0

@mesosphere-ci mesosphere-ci added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Sep 1, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 1, 2024
@mesosphere-ci mesosphere-ci added do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Sep 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/grafana-8.5.0

@coveralls
Copy link

coveralls commented Sep 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11049425096

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.515%
Totals Coverage Status
Change from base Build 11045208109: 0.0%
Covered Lines: 136
Relevant Lines: 264
💛 - Coveralls

@github-actions github-actions bot added services/kube-prometheus-stack services/centralized-grafana services/centralized-kubecost size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 2, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2024
@gracedo gracedo mentioned this pull request Sep 4, 2024
Closed
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 4, 2024
@tushar-wagh-nx tushar-wagh-nx added open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Sep 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/chartbump/grafana-8.5.0

d2iq-mergebot and others added 15 commits September 26, 2024 14:54
@d2iq-mergebot @tushar-wagh-nx
chore: Update grafana-logging 8.3.5 => 8.5.0
1961bb2
@d2iq-mergebot @tushar-wagh-nx
chore: Move grafana-logging/8.3.5 => 8.5.0
cdc0b4f
@d2iq-mergebot @tushar-wagh-nx
chore: Update project-grafana-logging 8.3.4 => 8.5.0
e7f265d
@d2iq-mergebot @tushar-wagh-nx
chore: Move project-grafana-logging/8.3.4 => 8.5.0
a97dd1a
@d2iq-mergebot @tushar-wagh-nx
build: Updated licenses.d2iq.yaml
c3245c5
@tushar-wagh-nx
Added changed for sidecar image detaiks with tag 1.27.6
1fb4aca
@tushar-wagh-nx
updated the licenses.d2iq.yaml file to add the dependency for k8s-sid…
0a5a520 
…ecar:1.26.1
@tushar-wagh-nx
updated the licenses.d2iq.yaml file to add the dependency for k8s-sid…
3c179c1 
…ecar:1.26.1
@tushar-wagh-nx
updated the k8s-sidecar in kube-prometheus-stack cm.yaml to 1.26.1
149d745
@tushar-wagh-nx
updated the k8s-sidecar in kube-prometheus-stack cm.yaml to 1.27.6
480cc75
@d2iq-mergebot @tushar-wagh-nx
build: Updated licenses.d2iq.yaml
f71221b
@tushar-wagh-nx
feat:updated the k8s-sidecar to 1.26.1-d2iq.1 in licenses.d2iq.yaml file
f1a92cf
@tushar-wagh-nx
feat:updated the k8s-sidecar to 1.26.1-d2iq.1 in cm.yaml files
dd51e23
@tushar-wagh-nx
feat:Added entry for k8s-sidecar:1.26.1-d2iq.1 in licenses.d2iq.yaml
d3fac0f
@tushar-wagh-nx
feat:Removed the older services of project-grafana-logging and grafan…
ecae43f 
…a-logging
mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
licenses.d2iq.yaml
@@ -82,7 +82,12 @@ resources:
- license_path: LICENSE.txt
ref: ${image_tag}
url: https://github.com/jimmidyson/configmap-reload
- container_image: ghcr.io/mesosphere/dkp-container-images/docker.io/kiwigrid/k8s-sidecar:1.25.3-d2iq.1
- container_image: ghcr.io/mesosphere/dkp-container-images/docker.io/kiwigrid/k8s-sidecar:1.26.1-d2iq.1
Copy link
Contributor

@mhrabovcin mhrabovcin Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't exist in the registry. Try using the quay.io/kiwigrid/k8s-sidecar:1.27.6

mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
licenses.d2iq.yaml Outdated
@@ -475,11 +480,16 @@ resources:
- license_path: LICENSE
ref: ${image_tag%-distro}
url: https://github.com/kiali/kiali
- container_image: ghcr.io/mesosphere/dkp-container-images/quay.io/kiwigrid/k8s-sidecar:1.26.1-d2iq.1
- container_image: quay.io/kiwigrid/k8s-sidecar:1.26.1
Copy link
Contributor

@mhrabovcin mhrabovcin Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try to use the newest one quay.io/kiwigrid/k8s-sidecar:1.27.6

mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
licenses.d2iq.yaml
sources:
- license_path: LICENSE
ref: ${image_tag%-d2iq.1}
url: https://github.com/kiwigrid/k8s-sidecar
- container_image: quay.io/kiwigrid/k8s-sidecar:1.27.4
Copy link
Contributor

@mhrabovcin mhrabovcin Sep 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try to use the newest one quay.io/kiwigrid/k8s-sidecar:1.27.6

mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
services/centralized-grafana/60.4.1/defaults/cm.yaml Outdated
Comment on lines 23 to 26
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a double sidecar yaml value.

Suggested change
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6

mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
services/kube-prometheus-stack/60.4.1/defaults/cm.yaml Outdated
Comment on lines 354 to 357
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6

mhrabovcin
mhrabovcin reviewed Sep 27, 2024
View reviewed changes
services/project-grafana-logging/8.5.0/defaults/cm.yaml Outdated
Comment on lines 31 to 34
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sidecar:
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6
image:
repository: quay.io/kiwigrid/k8s-sidecar
tag: 1.27.6

@gracedo
Copy link
Contributor

gracedo commented Oct 2, 2024

superseded by #2688 -- let's make the same changes if applicable to that branch

@gracedo gracedo closed this Oct 2, 2024
@gracedo gracedo deleted the chartbump/grafana-8.5.0 branch October 2, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhrabovcin mhrabovcin mhrabovcin left review comments

@SandhyaRavi2403 SandhyaRavi2403 Awaiting requested review from SandhyaRavi2403

Assignees

@tushar-wagh-nx tushar-wagh-nx

Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/centralized-grafana services/centralized-kubecost services/grafana-logging services/kube-prometheus-stack services/kubecost services/project-grafana-logging size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mesosphere-ci @coveralls @SandhyaRavi2403 @gracedo @mhrabovcin @shubham2g @tushar-wagh-nx @d2iq-mergebot