Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Change docker image, enable server build #2716

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: Change docker image, enable server build #2716

wants to merge 1 commit into from
+70 −27

Conversation

mikolajb
Copy link
Contributor

@mikolajb mikolajb commented Oct 9, 2024

What problem does this PR solve?:

Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-102822

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mikolajb mikolajb self-assigned this Oct 9, 2024
@mikolajb mikolajb requested a review from a team October 9, 2024 14:17
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2024
@mikolajb mikolajb force-pushed the mikolajb/enable-k-apps-server-push branch 4 times, most recently from f3500b1 to d31aabd Compare October 9, 2024 15:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11258658558

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.557%
Totals Coverage Status
Change from base Build 11258634272: 0.0%
Covered Lines: 149
Relevant Lines: 289
💛 - Coveralls

@gracedo gracedo added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takirala takirala Awaiting requested review from takirala

@gracedo gracedo Awaiting requested review from gracedo

At least 1 approving review is required to merge this pull request.

Assignees

@mikolajb mikolajb

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikolajb @coveralls @gracedo