Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Patch AI Navigator model size issues (backport to 2.12) #2860

Merged
merged 2 commits into from
Dec 9, 2024
Merged

feat: Patch AI Navigator model size issues (backport to 2.12) #2860

merged 2 commits into from
Dec 9, 2024

Conversation

lukeogg
Copy link
Contributor

@lukeogg lukeogg commented Nov 22, 2024 •
edited
Loading

What problem does this PR solve?:

Backports the model size issue fixes to 2.12.

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-104316 is the primary one.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@lukeogg lukeogg added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off backport-pr This is a backport PR labels Nov 22, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 22, 2024
kaiwalyajoshi
kaiwalyajoshi reviewed Nov 27, 2024
View reviewed changes
licenses.d2iq.yaml Outdated Show resolved Hide resolved
kaiwalyajoshi
kaiwalyajoshi requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@kaiwalyajoshi kaiwalyajoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to use the v1.29.6 kubectl images and using the patched version of Postgres that ships with NKP 2.12.x

licenses.d2iq.yaml Show resolved Hide resolved
services/ai-navigator-app/0.2.8/defaults/cm.yaml Outdated Show resolved Hide resolved
alembiewski
alembiewski reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@alembiewski alembiewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We changed the version of flux CRD in the latest agent release, and I'm not sure it's compatible with the flux we shopped in 2.12. I suggest exclude the agent from the patch since there is no need to patch it, only the api

services/ai-navigator-app/0.2.8/ai-navigator-app.yaml Outdated Show resolved Hide resolved
@lukeogg lukeogg changed the title feat: Patch AI Navigator to the latest version (backport to 2.12) feat: Patch AI Navigator model size issues (backport to 2.12) Dec 2, 2024
kaiwalyajoshi
kaiwalyajoshi approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@kaiwalyajoshi kaiwalyajoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock.

@lukeogg lukeogg force-pushed the logg/patch-ai-navigator-backport-2.12 branch from bcd4120 to 2d458b8 Compare December 4, 2024 23:09
@kaiwalyajoshi kaiwalyajoshi merged commit f3070ee into release-2.12 Dec 9, 2024
16 of 17 checks passed
@kaiwalyajoshi kaiwalyajoshi deleted the logg/patch-ai-navigator-backport-2.12 branch December 9, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alembiewski alembiewski alembiewski approved these changes

@kaiwalyajoshi kaiwalyajoshi kaiwalyajoshi approved these changes

Assignees
No one assigned
Labels
backport-pr This is a backport PR ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukeogg @kaiwalyajoshi @alembiewski