Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openapi.yaml #61

Merged

Conversation

hoavoh
Copy link
Contributor

@hoavoh hoavoh commented Jan 18, 2024

add status for a sender address as an own number

add status for a sender address as an own number
@@ -1906,11 +1905,10 @@ paths:
account_id: my_account,
created_date: 2023-08-14T04:21:55.958Z,
last_modified_date: 2023-08-14T04:21:55.958Z,
expiry: 2024-08-03T04:21:55.958Z
- id: 4a9cb0f4-f383-40b5-84dc-bbb6a3b210dd
sender_address: EXAMPLE3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to +61491570156

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change it, is it just to look more explicit?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's because it should be an international phone number, not an alpha tag 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, agree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

update sample response
@hoavoh hoavoh merged commit 68490cd into master Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants