Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent response format #660

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Agent response format #660

wants to merge 2 commits into from

Conversation

hanzlfs
Copy link

@hanzlfs hanzlfs commented Dec 19, 2024

What does this PR do?

Add response format for agents structured output.

Test Plan

E2E test plan with llama-stack-apps interior_design

Please describe:
Test ran:

  • provide instructions so it can be reproduced.
    Start your distro:
    llama stack run llama_stack/templates/fireworks/run.yaml --env FIREWORKS_API_KEY=<API_KEY>

Run api test:
PYTHONPATH=. python examples/interior_design_assistant/api.py localhost 5000 examples/interior_design_assistant/resources/documents/ examples/interior_design_assistant/resources/images/fireplaces

Sources

Results:
meta-llama/llama-stack-client-python#72

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 19, 2024
@hanzlfs hanzlfs closed this Dec 20, 2024
@hanzlfs hanzlfs reopened this Dec 20, 2024
@hanzlfs hanzlfs marked this pull request as ready for review December 20, 2024 19:52
@yanxi0830
Copy link
Contributor

Thanks! Could you add an integration test for this in https://github.com/meta-llama/llama-stack/blob/main/tests/client-sdk/agents/test_agents.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants