Revert "[Windows] Fix build issues using Clang-CL on Windows, add CI … #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eta-pytorch#121)" This reverts commit 4ed91cc.
meta-cla
bot
added
the
CLA Signed
larryliu0820
approved these changes
Oct 3, 2025
GregoryComer
added a commit
to GregoryComer/tokenizers
that referenced
this pull request
Oct 3, 2025
GregoryComer
added a commit
to GregoryComer/tokenizers
that referenced
this pull request
Oct 3, 2025
GregoryComer
added a commit
to GregoryComer/tokenizers
that referenced
this pull request
Oct 4, 2025
meta-pytorch#135) Summary: … (meta-pytorch#121)" (meta-pytorch#134) Re-apply Windows changes with lint fix. See the original PR (meta-pytorch#121) for more details. This PR is identical, except for remove a space before a `#pragma` in compiler.h. Differential Revision: D83882623 Pulled By: GregoryComer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#121)"
This reverts commit 4ed91cc.
Reverting due to Meta-internal lint failure. Will re-land shortly.