Add hash and equality functions to planner types #3522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff adds explicit `__hash__` and `__eq__` methods to custom objects in the torchrec planner that previously relied on Python's default object identity-based hashing. 1. **DeviceHardware** (fbcode/torchrec/distributed/planner/types.py): - Hash based on rank, storage, and perf fields - Equality checks all three fields 2. **BasicCommsBandwidths** (fbcode/torchrec/distributed/planner/types.py): - Hash based on inter_host_bw and intra_host_bw - Equality checks both bandwidth values Reviewed By: iamzainhuda Differential Revision: D85731424
meta-cla
bot
added
the
CLA Signed
Contributor
|
@gregmacnamara has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85731424. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds explicit
__hash__and__eq__methods to custom objects in the torchrec planner that previously relied on Python's default object identity-based hashing.Reviewed By: iamzainhuda
Differential Revision: D85731424