Look up and forward raw_ids from tracker to TBE from embedding module #3527
+71
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
@FriedCosey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86242001. |
…meta-pytorch#3527) Summary: We look up the identities corresponding to slot index from `raw_id_tracker` and forward it to TBE. The identities are stored in `raw_id_tracker` during `mc_module` lookup. `raw_ids` are retrieved per-table from `raw_id_tracker` with the api `get_indexed_lookup()`, we concatenat them to maintain 1-to-1 alignment with `features.values()`. Reviewed By: chouxi Differential Revision: D86242001
FriedCosey
force-pushed
the
export-D86242001
branch
from
1076264 to
f140635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We look up the identities corresponding to slot index from
raw_id_trackerand forward it to TBE. The identities are stored inraw_id_trackerduringmc_modulelookup.raw_idsare retrieved per-table fromraw_id_trackerwith the apiget_indexed_lookup(), we concatenat them to maintain 1-to-1 alignment withfeatures.values().Reviewed By: chouxi
Differential Revision: D86242001