Skip to content

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented Oct 17, 2025

When job is not found we will show State=UNKNOWN and surface the error in Msg

Test plan:
[x] added unit test
[x] torchx status sfai_kubernetes://torchx/real-namespace:bogus-job-id

AppStatus:
    State: UNKNOWN
    Num Restarts: -1
    Roles: 
    Msg: Not Found: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"jobs.batch.volcano.sh \"bogus-jobs-id\" not found","reason":"NotFound","details":{"name":"bogus-job-id","group":"batch.volcano.sh","kind":"jobs"},"code":404}

    Structured Error Msg: <NONE>
    UI URL: None

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 17, 2025
@clumsy
Copy link
Contributor Author

clumsy commented Oct 17, 2025

For your consideration @kiukchung @d4l3k
Looks like we might need the same for other APIs

@clumsy
Copy link
Contributor Author

clumsy commented Oct 17, 2025

setup_pyre.sh lacked +x so I added it here, don't think it justifies a full PR

@kiukchung
Copy link
Contributor

when the job is not found describe API should return None no?

@clumsy
Copy link
Contributor Author

clumsy commented Oct 20, 2025

Do you mean State: None? What would you like it to show @kiukchung ? I'm happy to update my fix as long as it's not an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants