-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More acceptance tests relevant to table permissions #101
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @crisptrutski and the rest of your teammates on Graphite |
02515ef
to
a038511
Compare
(def ^:private not-implemented? | ||
#{:basic-select}) | ||
(def global-overrides | ||
{:basic-select :macaw.error/not-implemented}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsmacdonald You should be able to just remove this entry to start TDD-ing the new walker.
(doseq [m test-modes] | ||
(when-let [ts (testing (str prefix " table analysis does not throw for mode " m) | ||
(is (ct/tables sql (opts-mode m))))] | ||
(if (not-implemented? m) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rework to this function is essentially to get rid of this override hidden in the test, so that :error
values in the expectations can do all the driving.
{:ast-walker-1 | ||
;; TODO currently each table gets hidden by the other CTE | ||
{:tables [] | ||
:source-columns []}}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels good to scope the one known false negative 😮💨
7a6e4a8
to
448554c
Compare
Merge activity
|
Preparing to build confidence around a more basic table-only analysis.