Playlist page: Prevent autofocus on add-track component #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This focus-on-load had a good intent, but it scrolls to the bottom of the page automatically which is annoying. In some components it is desirable, but not for the playlist page, so I added an autofocus option that defaults to true (keeps it the same for other components) There is a button at the top that takes you to the add-track component, so I made that trigger focus on the input component instead.
Now that we call the focus method on the addtrack input, this button should not be a link but an actual button instead
anshg1214
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until #3149 is merged, will probably need rebasing after that
This focus-on-page-load had a good intent, but on the playlist page it scrolls to the bottom of the page automatically which is annoying.
In some components it is desirable, but not for the playlist page, so I added an autofocus option that defaults to true (keeps it the same for other components).
There is a button at the top that takes you to the add-track component, so I made that trigger focus on the input component instead.