Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-13920 (I): Make feat. artist errors block submission #3468

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

derat
Copy link
Contributor

@derat derat commented Feb 9, 2025

MBS-13920

Add an errorField() call to the release editor to block edit submission if the user didn't click the checkbox to confirm that the appearance of featured artists in track titles was intentional. I think that this was accidentally omitted from ca19708.

Problem

An error is displayed if the user doesn't confirm that they meant to list a featured artist in a track title, but unlike all of the other errors in the tracklist editor, it doesn't block edit submission.

Solution

Add an errorField call to register an error if any of the mediums contain unconfirmed appearances of featured artists in track titles.

Testing

Checked locally that the "Enter edit" button is now disabled before I check the checkbox (but still enabled after).

Add an errorField() call to the release editor to block edit
submission if the user didn't click the checkbox to confirm
that the appearance of featured artists in track titles was
intentional. I think that this was accidentally omitted from
ca19708.
@derat
Copy link
Contributor Author

derat commented Feb 9, 2025

@reosarevok, mind taking a quick look and merging this if it looks fine? I figured I'd fix this first in a tiny separate change since the seeding-related issue seems like it might be a bit more work.

Copy link
Member

@reosarevok reosarevok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good, thanks - will merge for the next beta release.

@derat
Copy link
Contributor Author

derat commented Feb 14, 2025

@reosarevok or @mwiencek, mind merging this one too? Thanks!

@reosarevok reosarevok merged commit fe06c51 into metabrainz:master Feb 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants