Don't ignore disallowed children HTML errors #3482
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
force-pushed
the
punish-bad-children
branch
from
37796c9 to
a32be37
Compare
SidebarProperties is a dl, and IsrcList / IswcList return a hydrated div containing a separate dl. You cannot have the div inside a dl, but that's not even the main problem, since you also cannot have nested dls... This just needs to be alongside the SidebarProperties dl instead of inside of it. Nothing seems to change in the display on Chrome at least.
reosarevok
force-pushed
the
punish-bad-children
branch
from
a32be37 to
3c76407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now a draft to see how much if any test screaming this still causes.