Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] MBS-13768: Add MBIDs to mediums #3502

Draft
wants to merge 4 commits into
base: schema-change-2025-q2
Choose a base branch
from
Draft

[WIP] MBS-13768: Add MBIDs to mediums #3502

wants to merge 4 commits into from

Conversation

reosarevok
Copy link
Member

@reosarevok reosarevok commented Mar 20, 2025 •
edited
Loading

Implement MBS-13768

Description

This adds a MBID column to the medium table, and creates a new medium_gid_redirect table to store redirected MBIDs from merges.

Tasks

  • Update existing medium SQL tests to include the MBID column.
  • Test running the schema change.
  • Support MBIDs in Entity::Medium and Data::Medium.
  • Add redirects for medium MBIDs on "Merge mediums" release merges.
  • Use MBIDs when linking mediums (e.g. from release disc headers)
  • Add medium MBIDs to the XML WS
  • Add medium MBIDs to the JSON WS

Testing

None yet.

@reosarevok reosarevok added the New feature Non urgent new stuff label Mar 20, 2025
@reosarevok reosarevok changed the base branch from master to schema-change-2025-q2 March 20, 2025 14:02
@reosarevok reosarevok force-pushed the MBS-13768 branch 6 times, most recently from 55e1db1 to 47bcac1 Compare March 28, 2025 09:31
@reosarevok
[WIP] MBS-13768 (I): Add MBIDs to mediums (SQL)
9bf7e90 
This adds a MBID column to the medium table, and creates a new
medium_gid_redirect table to store redirected MBIDs from merges.
@reosarevok
MBS-13768 (II): Update tests for medium MBIDs
b201b4a
@reosarevok
[WIP] MBS-13768 (III): Load/add MBIDs for mediums
cac3e7d 
This also adds the IDs to the JSON API since they are loaded
by default and I see no reason blocking it. I will add them
to the XML API on a subsequent commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
New feature Non urgent new stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@reosarevok