Fixes for "Generate M3U playlist" #245 , along with all reviews required #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phw kindly look into this and if any more changes are required , inform me of the same , i'll make them as well , and If it meets requirements , kindly merge the same . I have made sure that there are no overlaps in the commits from prs this time .my sincerest apologies for that last time . |
|
@sambhavnoobcoder Thanks for getting this back on track. But as you changes essentially where a rebase of the existing PR, but reintroduced the str conversions that got removed in 239279c , I instead rebased the original #325 and merged that. Sorry if I caused confusion, but let's focus on your other PR #367, which is the far more interesting fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #245
made changes in the playlist.py to accommodate default playlist location to also work for multiple album selections. also takes into account the review changes from the past pr and makes sure that all necessary reviews from the last pr are accommodated in this pr .