Feat/build all casper circuits #271
Conversation
NikolayKostadinov21
requested review from
Dimo99,
Owliie and
Xearty
and removed request for
Dimo99,
Owliie and
Xearty
| let command_line_arguments: Vec<String> = args().skip(1).collect(); | ||
|
|
||
| if command_line_circuit.name != Circuits::all { | ||
| for (_, arg) in command_line_arguments.iter().enumerate() { |
There was a problem hiding this comment.
enumerate is useless if you are not using the index
| for (_, arg) in command_line_arguments.iter().enumerate() { | ||
| let arg_as_circuit = Circuits::from_str(&arg); | ||
| build_circuit(arg_as_circuit.unwrap()); | ||
| let path = format!("build/{}", arg_as_circuit.unwrap().to_string()); |
| let command_line_circuit: CommandLineCircuit = CommandLineCircuit::parse(); | ||
| let command_line_arguments: Vec<String> = args().skip(1).collect(); | ||
|
|
||
| if command_line_circuit.name != Circuits::all { |
There was a problem hiding this comment.
You are only using command_line_circuit to check if it's all and are not using it to determine which circuits you should build. You could just as well check if args()[1] is "all"
| circuit.save(&path, &gate_serializer, &hint_serializer); | ||
| } | ||
| } else { | ||
| for _circuit in Circuits::iter() { |
| #[derive(Debug, Eq, Hash, PartialEq, Copy, Clone, EnumString, Display, EnumIter)] | ||
| #[allow(non_camel_case_types)] | ||
| enum Circuits { | ||
| compute_shuffled_index_mainnet, |
There was a problem hiding this comment.
Rename these to Pascal case
| } | ||
|
|
||
| impl Circuits { | ||
| fn from_str(circuit_as_str: &str) -> Option<Circuits> { |
There was a problem hiding this comment.
EnumString already creates this function for you so this implementation is redundant. Moreover, you can provide casing in it to match the Pascal case of the enum corectly
| let circuit = builder.build(); | ||
| let hint_serializer = HintRegistry::<L, D>::new(); | ||
| let gate_serializer = GateRegistry::<L, D>::new(); | ||
| let command_line_circuit: CommandLineCircuit = CommandLineCircuit::parse(); |
There was a problem hiding this comment.
Rename CommandLineCircuit to CommandLineOptions
| Lazy::force(&circuit_weigh_justification_and_finalization); | ||
| })) | ||
| } | ||
| Circuits::all => OneOrAllCircuits::AllCircuits(vec
No description provided.