Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Fixed-size unsigned integer target types #340

Merged
merged 34 commits into from
Sep 26, 2024
Merged

[Feature] Fixed-size unsigned integer target types #340

merged 34 commits into from
Sep 26, 2024

Conversation

Xearty
Copy link
Contributor

@Xearty Xearty commented Jun 6, 2024

No description provided.

@Xearty Xearty force-pushed the feat/uint_target_types branch 2 times, most recently from 104bcd5 to 67965c8 Compare June 6, 2024 03:22
@Xearty Xearty marked this pull request as ready for review June 6, 2024 06:38
@Xearty Xearty requested a review from Dimo99 June 6, 2024 07:53
@Xearty Xearty force-pushed the feat/uint_target_types branch 8 times, most recently from dbb7cb5 to d8e838c Compare June 12, 2024 14:31
@Xearty Xearty changed the title Implement fixed size integer target types [Feature] Implement fixed size integer target types Jun 12, 2024
@Xearty Xearty changed the title [Feature] Implement fixed size integer target types [Feature] Fixed-size unsigned integer target types Jun 12, 2024
Dimo99
Dimo99 previously approved these changes Jun 17, 2024
View reviewed changes
@Xearty
feat(circuit_framework): Impl uint target types and implement zero, o…
4a18f28 
…ne and add
@Xearty
feat(circuit_framework): Implement div for uint targets
dcfa6bb
@Xearty
feat(circuit_framework): Implement mul for uint targets
bbf1ee1
@Xearty
feat(circuit_framework): Implement rem for uint targets
33ff88b
@Xearty
feat(circuit_framework): Implement less than or equal to for uint tar…
3555189 
…gets
@Xearty
refactor(circuit_framework): Refactor uint targets
14decf8
@Xearty
feat(circuit_framework): Implement Uint32Target and rename other Uint…
a13b57d 
… targets
@Xearty
revert(circuit_framework): Delete Uint32Target type because of shift …
7ab06e7 
…overflow
@Xearty
feat(circuit_framework): Implement equality for uint targets
54411df
@Xearty
feat(circuit_framework): Automatically implement the rest of the comp…
0f9901e 
…arison operators
@Xearty
feat(circuit_framework): Implement sub for uint targets
2342a3b
@Xearty
fix(circuit_framework): Fix a bug with gte for uint targets
b3c17ff
@Xearty
feat(circuit_framework): Implement constant for uint targets
62b9e94
@Xearty
refactor(circuit_framework): Delete unused stuff
621a16b
@Xearty
refactor(circuit_framework): Delete unnecesarry qualification
d92298f
@Xearty
feat(circuit_framework): Implement serialization/deserialization for …
b1875b3 
…uint target types
@Xearty
feat(circuit_framework): Implement ssz serialization for Uint64Target
f76019a
@Xearty
feat(circuit_framework): Implement to_biguint to uint targets
c3120e1
@Xearty
refactor(circuit_framework): Refactor ssz_hash_tree_root to use pad…
5b46705 
…_using and to not allocate vecs
@Xearty
feat(circuit_framework): Implement u64/str and u128/str serde
04ff69c
@Xearty
feat(circuit_framework): Implement le_bits converters for uint targets
b82067b
@Xearty
feat(circuit_framework): Implement le_bytes conversions for uint targets
63b7891
@Xearty
feat(circuit_framework): Implement biguint truncation for uint targets
91211d6
@Xearty
feat(circuit_framework): Implement to_be_bits for uint targets
994b9b4
@Xearty
fix(circuit_framework): Fix ssz_hash_tree_root for Uint64Target
7b4c911
@Xearty
refactor(circuit_framework): Change the order of parameters of uint t…
1720b69 
…arget's `constant` method
@Xearty
fix(circuit_framework): Assert the uint limbs are valid properly
70f136a
@Xearty
refactor(circuit_framework): Derive the number of limbs from the prim…
9841e1c 
…itive type of uint target
@Xearty
refactor(circuit_framework): Rename uint target definition macro
79ba305
@Xearty
refactor(circuits): Make circuits use fixed-size uint targets
28f993f
@Xearty
refactor(circuit_framework): Implement ssz_hash_tree_root for `Bool…
5b18507 
…Target` and delete obsolete function
@Xearty
refactor(): Document get_balance_from_leaf function
87fffd3
@Xearty
refactor(): Delete unused function biguint_is_equal_non_equal_limbs
05f13d8
@Xearty
refactor(): Delete unused biguint utility functions and renaming
ce64884
PetarKirov
PetarKirov approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it, LGTM 🙈

@PetarKirov PetarKirov enabled auto-merge (rebase) September 26, 2024 15:50
@PetarKirov PetarKirov merged commit b4aa98f into main Sep 26, 2024
13 checks passed
@PetarKirov PetarKirov deleted the feat/uint_target_types branch September 26, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dimo99 Dimo99 Dimo99 approved these changes

@PetarKirov PetarKirov PetarKirov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xearty @PetarKirov @Dimo99