New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diva deployment quick fix #351

Closed

Dimo99 wants to merge 17 commits into set_verifier_digest from diva_deployment_quick_fix

Collaborator

Dimo99 commented Jun 12, 2024

No description provided.

Dimo99 requested review from Xearty and Owliie

June 12, 2024 14:51

Xearty reviewed

View reviewed changes

beacon-light-client/plonky2/input_fetchers/publisher/balance-verifier-publisher-diva.ts Outdated Show resolved Hide resolved

Xearty reviewed

View reviewed changes

beacon-light-client/plonky2/input_fetchers/publisher/balance-verifier-publisher-lido.ts Outdated Show resolved Hide resolved

Xearty reviewed

View reviewed changes

beacon-light-client/plonky2/input_fetchers/publisher/balance-verifier-publisher-lido.ts Outdated Show resolved Hide resolved

Xearty reviewed

View reviewed changes

beacon-light-client/plonky2/input_fetchers/publisher/balance-verifier-publisher-lido.ts Outdated Show resolved Hide resolved

Xearty reviewed

View reviewed changes

beacon-light-client/plonky2/input_fetchers/publisher/balance-verifier-publisher-lido.ts Outdated Show resolved Hide resolved

Xearty reviewed

View reviewed changes

beacon-light-client/plonky2/input_fetchers/publisher/balance-verifier-publisher-lido.ts

Contributor

Xearty Jun 12, 2024

Imo publishers should not be in input_fetchers

Collaborator Author

Dimo99 Jun 13, 2024

yeah, but I didn't want to define another package.json just for the publishers. Also it doesn't make sense to be in solidity folder as it does not rely on hardhat and it also uses a lot of the structures from the redis defined in the input_fetchers thing

Contributor

Xearty Jun 18, 2024

I think this needs to be a separate workspace

Xearty reviewed

View reviewed changes

beacon-light-client/plonky2/input_fetchers/publisher/balance-verifier-publisher-lido.ts Outdated Show resolved Hide resolved

Xearty reviewed

View reviewed changes

...lonky2/input_fetchers/balance_verification/withdrawal_credentials/runnable/diva_scheduler.ts Outdated Show resolved Hide resolved

Xearty reviewed

View reviewed changes

...lonky2/input_fetchers/balance_verification/withdrawal_credentials/runnable/diva_scheduler.ts Outdated Show resolved Hide resolved

Xearty reviewed

View reviewed changes

...lonky2/input_fetchers/balance_verification/withdrawal_credentials/runnable/diva_scheduler.ts Outdated Show resolved Hide resolved

Xearty reviewed

View reviewed changes

beacon-light-client/solidity/tasks/deploy-accumulator.ts

Comment on lines +3 to +19

+              const depositItems = [
+                {
+                  pubkey:
+                    '0xaaf6c1251e73fb600624937760fef218aace5b253bf068ed45398aeb29d821e4d2899343ddcbbe37cb3f6cf500dff26c',
+                  withdrawalCredentials:
+                    '0x0048281f02e108ec495e48a25d2adb4732df75bf5750c060ff31c864c053d28d',
+                  signature:
+                    '0xa89660de6049478c8459383235b8ffaf8be15fd16fc93ea65db6e51e80eaba9c291a9a1bda98d08740a89b3226e89b9804c0f1760e4483d26d33b465fc13565e77a8430900ca245a2b628546abfa6172c758ab81d23bd360bb233a2771242f8f',
+                  depositDataRoot:
+                    '0xfce4b23c858a57df1af11aa3fec24b4d50e8048366aa88fbf2bf8b6c6f877b71',
+                },
+                {
+                  pubkey:
+                    '0x8aa5bbee21e98c7b9e7a4c8ea45aa99f89e22992fa4fc2d73869d77da4cc8a05b25b61931ff521986677dd7f7159e8e6',
+                  withdrawalCredentials:
+                    '0x0034432b9814c1972e63d60d763584ceea8542de8d397120136e60d731b2de31',
+                  signature:

Contributor

Xearty Jun 12, 2024

Stick these in a json and import it

Xearty reviewed

View reviewed changes

relay/implementations/beacon-api.ts Outdated Show resolved Hide resolved

Dimo99 requested a review from Xearty

June 18, 2024 10:37

Dimo99 added 15 commits

June 18, 2024 13:54


          fix(contracts) Verifier digest mutability

13df17a


          fix: Add withdrawal-credentials as options

c244a17


          fix: Publisher bug with number of slashed validators

b83b693


          fix: Some properties handling at infinity

45a4b88


          fix: diva scheduler script

dee2667


          fix: Return withdrawal credential flag to balance verification script

29a105c


          fix: Unformated hex input handling

2804b72


          fix: Make balance publisher work with custom rpc

a528eaa


          fix: Update verifier contract

fe4c166


          fix: Balance verifier publisher

47d60e0


          fix: Downgrade plonky2

0413d6a

gnark-plonky2-verifier breaks if we upgrade the plonky2 version so we stick with tag v0.2.0 used in plonky2x


          feat: Add diva publisher task

d52905f


          fix: Lido deploy-balance-verifier

97f5411


          fix: Balance verifier diva block number

56da145


          fix: Add deploy-accumulator for testing purposes

b1f72f5

Dimo99 added 2 commits

June 18, 2024 13:55


          fix: CR comments

8a92962


          feat: Add diva scheduler for deposits accumulator

de7a0f9

Dimo99 force-pushed the diva_deployment_quick_fix branch from d0ca94f to de7a0f9 Compare

June 18, 2024 10:55

Dimo99 changed the base branch from main to set_verifier_digest

June 18, 2024 10:56

Xearty reviewed

View reviewed changes

...hers/balance_verification/deposits_accumulator/runnable/diva_balance_aggregator_scheduler.ts

+                  redisPort: options['redis-port'],
+                  address: options['address'],
+                  rpcUrl: options['json-rpc'],
+                  protocol: options['protocol'],

Contributor

Xearty Jun 18, 2024

The protocol is diva, why is this configurable?

Xearty approved these changes

View reviewed changes

Owliie approved these changes

View reviewed changes

PetarKirov force-pushed the set_verifier_digest branch 3 times, most recently from 6538d38 to 8a671b8 Compare

August 28, 2024 16:15

Collaborator

PetarKirov commented Sep 26, 2024

Closing this PR, since diva_deployment_quick_fix is already part of it's already part of diva-deployment.

PetarKirov closed this

PetarKirov deleted the diva_deployment_quick_fix branch

September 26, 2024 13:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet