Relay upgrade #373
Relay upgrade #373
Conversation
kkirkov
force-pushed
the
relay-upgrade
branch
3 times, most recently
from
60a23bd
to
b208715
Compare
kkirkov
force-pushed
the
relay-upgrade
branch
5 times, most recently
from
72cbd31
to
b7df04e
Compare
Dimo99
force-pushed
the
relay-upgrade
branch
from
c8047e8
to
0c7d521
Compare
Dimo99
force-pushed
the
relay-upgrade
branch
from
bc8257f
to
bd41443
Compare
Dimo99
force-pushed
the
relay-upgrade
branch
from
bd41443
to
e7d78ff
Compare
kkirkov
force-pushed
the
relay-upgrade
branch
4 times, most recently
from
69234ee
to
a585b4d
Compare
Dimo99
force-pushed
the
relay-upgrade
branch
3 times, most recently
from
2d6472a
to
656633a
Compare
kkirkov
force-pushed
the
relay-upgrade
branch
from
8a4dab5
to
98f9bed
Compare
| @@ -71,6 +72,32 @@ export async function publishTransaction( | |||
| }); | |||
| } | |||
|
|
|||
| switch (chainId) { | |||
There was a problem hiding this comment.
Here you can use the data-driven programming approach as @PetarKirov suggested
But it can be done in a following PR.
| export enum NetworkConfig { | ||
| Pratter = 'pratter', | ||
| Mainnet = 'mainnet', | ||
| Sepolia = 'sepolia', | ||
| Chiado = 'chiado', | ||
| } | ||
|
|
||
| export function isSupportedFollowNetwork(network: string): boolean { | ||
| return Object.values(NetworkConfig).includes(network as NetworkConfig); | ||
| } |
There was a problem hiding this comment.
Can you remind me why Enum but not union type?
Not a blocker, just wandering.
There was a problem hiding this comment.
Enum is what I had in mind, remade it with union as it makes more sence
vendor/snarkjs
Outdated
There was a problem hiding this comment.
This looks scary. It's nice to see it worked out!
.env.example
Outdated
| BEACON_REST_API_PRATTER= | ||
| BEACON_REST_API_MAINNET= | ||
| BEACON_REST_API_SEPOLIA= | ||
| BEACON_REST_API_CHIADO= | ||
| REDIS_HOST=localhost |
There was a problem hiding this comment.
Why are so many empty? Smt forgotten or?
There was a problem hiding this comment.
The public api-s I know of are not very stable so I wouldnt recommend them(could still add those here I guess), the Light-client contracts(LC_Sepolia) and the Hashi contracts(Sepolia_Hashi) are for whoever is using DendrETH to create them and add to his .env file and as for the RPCs yes I can add those but anyone can find them with a quick google search so I dont feel like thats necessary
kkirkov
dismissed stale reviews from EmilIvanichkovv and Dimo99
via
150bb83
kkirkov
force-pushed
the
relay-upgrade
branch
from
98f9bed
to
150bb83
Compare
Implement changes that were proposed by reviews of #284
Those suggestions can be found in comments in the above PR and on: https://coda.io/d/_d6vM0kjfQP6#My-Tasks_tuy0e/r1012&view=modal