feat/mcl/jcli #235
Open
feat/mcl/jcli #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
monyarm
commented
Apr 3, 2025
monyarm
commented
- feat(mcl): Add commandline argument support
- feat(mcl/utils/log): Implement errorAndExit function
- feat(mcl/utils/process): Add support to execute function, for supplying redirect; Improve execute function argument escaping, to not escape globs
- feat(mcl/config): Implement mcl config command
- refactor(mcl/dub): Remove deprecated dflags for improved build configuration
- fix(ci_matrix): Initialize params directly in ci_matrix function
- fix(utils/cachix): Modify getCachixDeploymenApiUrl definition, to allow compilation with newer d compiler versions.
- feat(mcl/main): Integrate argparse for command-line argument parsing and enhance command handling
- feat(commands/get_fstab): Enhance get_fstab command with argparse integration and structured argument handling
- feat(commands/deploy_spec): Enhance deploy_spec command with argparse integration and structured argument handling
- feat(commands/host_info): Enhance host_info command with argparse integration and structured argument handling
- feat(commands/config): Enhance config command with argparse integration and structured argument handling
- feat(commands/machine): Enhance machine command with argparse integration and structured argument handling
- feat(commands): Enhance ci/matrix commands with argparse integration and structured argument handling where applicable
monyarm
force-pushed
the
feat/mcl/jcli
branch
2 times, most recently
from
662b512 to
a999476
Compare
Merged
…and enhance command handling
…egration and structured argument handling
… integration and structured argument handling
…egration and structured argument handling
…on and structured argument handling
…tion and structured argument handling
…and structured argument handling where applicable
… for host info retrieval
|
Thanks for your Pull Request! This comment will be updated automatically with the status of each package. |
reo101
requested changes
Jun 11, 2025
Comment on lines
+29
to
+42
| const char[] genSubCommandArgs = | ||
| "@SubCommands\n"~ | ||
| "SumType!("~ | ||
| "get_fstab_args,"~ | ||
| "deploy_spec_args,"~ | ||
| "host_info_args,"~ | ||
| "config_args,"~ | ||
| "machine_args,"~ | ||
| "ci_matrix_args,"~ | ||
| "ci_args,"~ | ||
| "print_table_args,"~ | ||
| "shard_matrix_args,"~ | ||
| "Default!unknown_command_args"~ | ||
| ") cmd;"; |
There was a problem hiding this comment.
Could this be done in a similar fashion to the following genSubCommandMatch template?
| LogLevel logLevel = LogLevel.info; | ||
| args.getopt("log-level", &logLevel); | ||
| @(Command(" ").Description(" ")) | ||
| struct unknown_command_args {} |
There was a problem hiding this comment.
Prefer capitalized names (PascalCase, to be exact) for structs. Applies to the rest of the _args structs too.
Comment on lines
-189
to
+195
| export void print_table(string[] args) | ||
| @(Command("print-table", "print_table").Description("Print a table of the cache status of each package")) | ||
| struct print_table_args | ||
| { | ||
| } | ||
|
|
||
| export int print_table(print_table_args args) |
There was a problem hiding this comment.
Can we instead try supporting argument-less commands by providing an aptly argument-less function returning void, with genSubCommandArgs being updated to dynamically check whether or not each sub-command handler function has arguments/return value at all before taking them into account?
This also applies to all _args structs annotated with @(Command(" ").Description(" ")).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.