Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make template editor work at http://localhost:4200 #952

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

beepsoft
Copy link

Changed the way KeycloakUserHandler calculates the auth endpoint when editor is run at http://localhost:4200. For now it takes the value from window.authBase set in version.js by gulpfile.js. There's surely a better way to do this.

For this to work keycloak-realm.CEDAR.development.2023-07-05.json also needs to be updated in cedar-docker-build:
{
"clientId" : "cedar-angular-app",
...
"redirectUris" : [ ..., "http://localhost:4200", "http://localhost:4200/"],
"webOrigins" : [ ..., "http://localhost:4200", "http://localhost:4200/
"],
}

Changed the way KeycloakUserHandler calculates the auth endpoint when
editor is run at http://localhost:4200. For now it takes the value
from window.authBase set in version.js by gulpfile.js. There's surely
a better way to do this.

For this to work  keycloak-realm.CEDAR.development.2023-07-05.json also
needs to be updated in cedar-docker-build:
{
    "clientId" : "cedar-angular-app",
    ...
    "redirectUris" : [ ..., "http://localhost:4200", "http://localhost:4200/*"],
    "webOrigins" : [ ..., "http://localhost:4200", "http://localhost:4200/*"],
 }
@egyedia
Copy link
Member

egyedia commented Nov 14, 2023

We need to further discuss this PR before merging.
When developing locally, although we run the main frontend with gulp, and that serves it up on http 4200, we do not access it directly.
We do access it through nginx, using https://cedar.metadatacenter.orgx .
Please describe the use case which is covered by this modification.

@beepsoft
Copy link
Author

This would allow developing the frontend independently of the location of the backend, which in my case is in a VM, but it could be in the cloud as well. From the fronted development point of view both of these are remote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants