Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend HttpOpener. #463

Merged
merged 12 commits into from
Sep 8, 2022
Merged

Extend HttpOpener. #463

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3f7e150
Extend `HttpOpener`.
blackwinter Aug 26, 2022
28d9db8
Add content type header (#460)
dr0i Aug 29, 2022
6db8a3e
Reformat (#460)
dr0i Aug 29, 2022
72c5d69
Improve documentation (#460)
dr0i Aug 29, 2022
2a5ef5f
Add CONTENT_TYPE_DEFAULT (#460)
dr0i Aug 29, 2022
c314664
Remove CONTENT_TYPE_DEFAULT (#460)
dr0i Aug 29, 2022
e5f5753
Update documentation for `HttpOpener`. (#463)
blackwinter Sep 1, 2022
aaefc6c
Track response body support for `HttpOpener.Method`. (#463)
blackwinter Sep 1, 2022
864f0da
Handle HTTP errors in `HttpOpener`. (#463)
blackwinter Sep 1, 2022
ea537d7
Add unit tests for `HttpOpener`. (#463)
blackwinter Sep 1, 2022
75c7ef5
Update documentation for `HttpOpener`. (#463)
blackwinter Sep 2, 2022
b672731
Fix error stream handling for `HttpOpener`. (#463)
blackwinter Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions metafacture-io/src/main/java/org/metafacture/io/HttpOpener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,13 @@ public final class HttpOpener extends DefaultObjectPipe<String, ObjectReceiver<R
private static final Pattern HEADER_FIELD_SEPARATOR = Pattern.compile("\n");
private static final Pattern HEADER_VALUE_SEPARATOR = Pattern.compile(":");

private static final String ACCEPT_HEADER = "accept";
private static final String ENCODING_HEADER = "accept-charset";
private static final String ACCEPT_DEFAULT = "*/*";
private static final String CONTENT_TYPE_HEADER = "content-Type";
private static final String CONTENT_TYPE_DEFAULT = "application/json";
private static final String ACCEPT_HEADER = "accept";
private static final String CONTENT_TYPE_HEADER = "content-type";
private static final String DEFAULT_PREFIX = "ERROR: ";
private static final String ENCODING_DEFAULT = "UTF-8";
private static final String ENCODING_HEADER = "accept-charset";
private static final String INPUT_DESIGNATOR = "@-";
private static final String DEFAULT_PREFIX = "ERROR: ";

private static final Method DEFAULT_METHOD = Method.GET;

Expand Down Expand Up @@ -98,7 +97,7 @@ private boolean getInputAsBody() {
*/
public HttpOpener() {
setAccept(ACCEPT_DEFAULT);
setContentType(CONTENT_TYPE_DEFAULT);
setContentType(ACCEPT_DEFAULT);
blackwinter marked this conversation as resolved.
Show resolved Hide resolved
setEncoding(ENCODING_DEFAULT);
setErrorPrefix(DEFAULT_PREFIX);
setMethod(DEFAULT_METHOD);
Expand Down