-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter to table #52
base: master
Are you sure you want to change the base?
Conversation
Provides a sortable HTML table. To test: checkout the branch and point your browser's URL to: |
Thinking about it - no. We indeed need filter. |
The flux-commands-table.html is a HTML view of flux-commands.md with filter and sort functionality of the signature of the commands. Proof of concept - WIP
60f5cd1
to
70e9743
Compare
The HTML table comes now with filter for the signature. The |
I thinik this table is cool, but I do not know If we should duplicate the documentation. Also the page should be implemented into the just-the-docs template. Perhaps we should only add the name of the function linking to the documentation and the sig in and sog out column. |
Discussed with @maipet and @TobiasNx we should try to integrate the table into our documentation, at best instead of https://metafacture.github.io/metafacture-documentation/docs/flux/flux-commands.html. What's missing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the functionality, although I would prefer to be able to filter the other columns as well (especially the command column); I've had good success with jQuery Tablesorter.
Maybe you want to reference your source?
Proof of concept - WIP
Question is: is this HTML table useful?
from metafacture/metafacture-core#369:
Would this HTML table provide the needed functionality?