New Governance Process SlackAdvancedVote to the Slack Plugin
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user's vote is public or not
…to put in the policykit logic)
amyxzhang
reviewed
May 19, 2023
| @@ -141,7 +141,7 @@ def quality_is_greater(a, b): | |||
| return order.index(a) > order.index(b) | |||
|
|
|||
|
|
|||
| class Plugin(models.Model): | |||
| class Plugin(models.Model ): | |||
| @@ -191,10 +191,9 @@ def start_process(self, process_name, callback_url=None, **kwargs): | |||
| """Start a new GovernanceProcess""" | |||
| # Find the proxy class for the specified GovernanceProcess | |||
| cls = self.__get_process_cls(process_name) | |||
|
|
|||
| ADVANCED_VOTE_ACTION_ID = "advanced_vote" | ||
|
|
||
| @Registry.governance_process | ||
| class SlackAdvancedVote(GovernanceProcess): |
There was a problem hiding this comment.
instead of calling this advanced vote, since this is somewhat vague, what about calling it SlackMultichoiceVote or SlackElectionVote?
There was a problem hiding this comment.
Is this class meant to represent different kinds of more advanced votes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is similar to SlackEmojiVote.
This new governance process accepts a list of candidates and options and then initiates a vote in Slack where users can select an option for each candidate. The outcome of the vote will be stored as a dict {user: {candidate1: option1, ...}, }
To allow the new governance to receive webhook events, in the
handlers.pyof Slack, we also check whether the actions of the payload are isVOTE_ACTION_IDor start withADVANCED_VOTE_ACTION_ID), and pass events to the corresponding governance process.