Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message on firewall controller version not found. #202

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Improve error message on firewall controller version not found. #202

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c68781d
Improve error message on firewall controller image not found.
Gerrit91 Aug 2, 2021
d11eee2
Merge remote-tracking branch 'origin/master' into nicer-error-message
Gerrit91 Jul 24, 2023
10a1b73
Make up the PR.
Gerrit91 Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pkg/apis/metal/validation/firewall_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,18 @@ func ValidateFirewallControllerVersion(availableVersions []apismetal.FirewallCon
return getLatestFirewallControllerVersion(availableVersions)
}

for _, availableVersion := range availableVersions {
var versions []string
for _, v := range availableVersions {
availableVersion := v

if availableVersion.Version == specVersion {
return &availableVersion, nil
}

versions = append(versions, availableVersion.Version)
}

return nil, fmt.Errorf("firewall controller version:%s was not found in available versions: %v", specVersion, availableVersions)
return nil, fmt.Errorf("firewall controller version %q was not found in available versions: %v", specVersion, versions)
}

func getLatestFirewallControllerVersion(availableVersions []apismetal.FirewallControllerVersion) (*apismetal.FirewallControllerVersion, error) {
Expand Down