Machine Registration must now contain Partition #583
+393
−737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwennrich
approved these changes
Oct 11, 2024
Gerrit91
approved these changes
Oct 11, 2024
…o pass-partition-to-machine-register
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Closes #issue.
Additional Description
During the machine registration, not all switches must be fetched to calculate the machine connections, it is sufficient to just fetch the switches in the same partition as the machine.
This will speed up registration and reduces load on the metal-api.
Requires updated pixie-core and metal-hammer as described in the dependencies.
Release Notes
When a machine is registered, the partition id must be provided by metal-hammer. This reduces the amount of switches which need to be fetched to calculate the machine connections.