Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fec config from sonic applier #132

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Remove fec config from sonic applier #132

merged 2 commits into from
Oct 16, 2024

Conversation

iljarotar
Copy link
Contributor

@iljarotar iljarotar commented Sep 23, 2024 •
edited
Loading

Breaking Change

metal-core does not write FEC configuration on ports anymore. If FEC is needed, it must be configured another way, e.g. by Ansible.

@iljarotar iljarotar requested a review from a team as a code owner September 23, 2024 10:09
robertvolkmann
robertvolkmann approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@robertvolkmann robertvolkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document this breaking change!

robertvolkmann
robertvolkmann requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@robertvolkmann robertvolkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metal-core/cmd/internal/switcher/sonic/db/asicdb.go

Line 59 in 4ab8042

func (d *AsicDB) InFecModeRs(ctx context.Context, port OID) (bool, error) {

metal-core/cmd/internal/switcher/sonic/db/configdb.go

Line 21 in 4ab8042

fec = "fec"

@majst01 majst01 merged commit 4be4306 into master Oct 16, 2024
1 check passed
@majst01 majst01 deleted the remove-fec-config branch October 16, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majst01 majst01 majst01 approved these changes

@robertvolkmann robertvolkmann robertvolkmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iljarotar @majst01 @robertvolkmann