Use running configuration for sonic ports #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2024 15:39
iljarotar
force-pushed
the
use-running-cfg-for-sonic-ports
branch
from
f83fc49
to
f1080cc
Compare
robertvolkmann
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Replaces #323
Additional Description
This is a compromise that doesn't introduce any breaking changes. Default mtu, speed and fec for SONiC ports can still be used. Additionally, if the running configuration holds values for mtu, speed and fec these values will be considered for the new config. The reasoning behind this PR is that all values that are not explicitly defined should remain as they are, while the current template will remove mtu and fec from ports, that are not part of the
sonic_portsdictionary.