fix: bug which required optional hmac type #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you already implemented a validation of |
Comment on lines
+227
to
+231
| if hmacAuthType != "" { | ||
| client, err = metalgo.NewDriver(driverURL, apiToken, hmacKey, metalgo.AuthType(hmacAuthType)) | ||
| } else { | ||
| client, err = metalgo.NewDriver(driverURL, apiToken, hmacKey) | ||
| } |
There was a problem hiding this comment.
You can set default values in viper!
There was a problem hiding this comment.
You mean like this? Unsure if its better than the if statement, but I can change it, if you like.
viper.SetDefault("hmac-auth-type", ctx.HMACAuthType)
hmacAuthType := viper.GetString("hmac-auth-type")
|
No, currently there is no validation of the hmac type. Neither on the client side, nor on the server side. Technically it could be any string. Currently there aren't even constants |
robertvolkmann
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If not given, this will rely on the default server behavior.
Alternatively: make this hmac type mandatory in the config and make this a breaking change.