Release amd64 and arm64 versions #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majst01
reviewed
Jul 6, 2024
|
@vknabel would you please check if this is valid |
majst01
reviewed
Jul 19, 2024
|
Hi, thanks for your contribution, it would be nice if you can align this multi arch build the way we build one of our binaries like seen here: https://github.com/metal-stack/metalctl/blob/master/Makefile |
|
Hello, |
majst01
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR add support for release both
amdandarm64 version. I have make it modular to easily add more release.This also remove useless
relfolder from the repo.This code was inspired by https://github.com/VictoriaMetrics/VictoriaMetrics.
Note: i havent tried if this broke following step :
Upload image tarballs to GCSThanks