update dependencies #258
Merged
update dependencies #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like in other controllers, here we do a general dependency update as well as explicitly update to metal-toolbox versions of bmclib, bmc-common and rivets/v2. Unlike the flasher case we maintain the current (if suboptimal) usage of the FleetDB API, because we don't have to tackle that immediately because of removing the rivets fleetdb module.
jakeschuurmans
previously approved these changes
Nov 21, 2024
coffeefreak101
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in other controllers, here we do a general dependency update as well as explicitly update to metal-toolbox versions of bmclib, bmc-common and rivets/v2.
Unlike the flasher case we maintain the current (if suboptimal) usage of the FleetDB API, because we don't have to tackle that immediately; it did not use the now-removed rivets fleetdb module.