Fix both disk wipe and deprecated command invocations #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo when doing the first rename.
Shallow copy also gets us the flags, without the shallow copy the Run will error accessing non-existent flags.
Was missing --timeout and should have use --debug like the rest of the commands instead of --verbose.
splaspood
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not notice that the deprecated commands I setup were missing the flags and would fail to run. My initial attempt to deprecate the old names did nothing until I set the
Runattribute but then I failed to notice that the args were missing and theRunwould fail. I have checked that both old and new funcs actually run this time though.Also ran into cli flags for disk wipe. I had the missing flags at one point while testing stuff out but then just totally forgot to re-run/test when I replaced
verbosewith pre-existingdebug. I ran a wipe with/without timeout,debug to make sure it works as expected, including a tiny timeout that causes the command to abort/error out.