Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: work for prow monitoring #841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NymanRobin
Copy link
Member

@NymanRobin NymanRobin commented Aug 23, 2024

NOTE: This is a draft and is not ready to be merged

It is basically based on the monitoring stack found under kubernetes test-infra monitoring and also the kubernetes-mixins.

The most important part of this if it is to be used as a base for further work is the README.md file which has instructions how to setup kubernetes-mixins locally and can provide a good ground for future work. To be noted the kustomize deployment is not tested the stack has only been tested with helm.

  • Figure out how to dynamically generate the mixins and deploy them, while also keeping them up to date.
  • Same as above for the prometheus monitoring and alert rules
  • Create the kustomize.yaml to mount the dashboards to the grafana pod and the slack webhook as a secret for the alertmanager, also referencing all the components that are needed for the monitoring stack itself
  • Figure out the ingress, this pr sets a new endpoint /monitoring but it could be done through a new subdomain as well monitoring.prow.apps.test.metal3.io/ would need to be requested from CNCF

The huge amount of file is since the mixins of prow and kubernetes are generated here, in the other projects it seems it is preferred to dynamically generate these when needed so might be worth to look into

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tuminoid for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NymanRobin
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 23, 2024
@metal3-io-bot
Copy link
Collaborator

@NymanRobin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
markdownlint aa9b4ba link true /test markdownlint
spellcheck aa9b4ba link true /test spellcheck

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants