Skip to content
This repository has been archived by the owner on May 4, 2020. It is now read-only.

Add support for flow-runtime. #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

izaakschroeder
Copy link
Contributor

@izaakschroeder izaakschroeder commented Feb 2, 2018

Automagically cast types!

Good: Get runtime type safety for "free" (no additional code writing). Nice errors.
Bad: Performance and/or bundle size.

"htmlescape": "^1.1.1",
"immutable": "^3.8.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill it

assert: (input: any) => T,
};
declare var reify: any;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this not have available lib types?!

@@ -1 +1 @@
9
9.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update package.json/engines as well

@10xjs
Copy link
Contributor

10xjs commented Feb 4, 2018

Would there be any value in using flow-runtime in non-prod builds only? It doesn't look like there is any built in support for this, we would have to roll our own solution (gajus/flow-runtime#36).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants