Merge pull request #23 from fedepaol/fixvolkswagen

E2E: return error when the condition is not valid
metallb · Jul 17, 2023 · 0837ace · 0837ace
2 parents 333684a + e083430
commit 0837ace
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/e2etests/tests/validate.go b/e2etests/tests/validate.go
@@ -49,7 +49,7 @@ func ValidatePrefixesForNeighbor(neigh frrcontainer.FRR, nodes []v1.Node, prefix
 			found, err := routes.CheckNeighborHasPrefix(neigh, prefix, nodes)
 			framework.ExpectNoError(err)
 			if !found {
-				fmt.Errorf("Neigh %s does not have prefix %s", neigh.Name, prefix)
+				return fmt.Errorf("Neigh %s does not have prefix %s", neigh.Name, prefix)
 			}
 		}
 		return nil
@@ -63,7 +63,7 @@ func ValidateNeighborNoPrefixes(neigh frrcontainer.FRR, nodes []v1.Node, prefixe
 			found, err := routes.CheckNeighborHasPrefix(neigh, prefix, nodes)
 			framework.ExpectNoError(err)
 			if found {
-				fmt.Errorf("Neigh %s has prefix %s", neigh.Name, prefix)
+				return fmt.Errorf("Neigh %s has prefix %s", neigh.Name, prefix)
 			}
 		}
 		return nil