E2E tests: dump failure information #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Paolinelli <[email protected]>
Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol
force-pushed
the
dumpfailure
branch
4 times, most recently
from
2fcd324
to
3a8641d
Compare
liornoy
reviewed
Jul 3, 2023
e2etests/pkg/dump/frr.go
Outdated
|
|
||
| func BGPInfo(testName string, FRRContainers []*frrcontainer.FRR, cs clientset.Interface, f *framework.Framework) { | ||
| if ReportPath == "" { | ||
| log.Fatalf("ReportPath is not set") |
There was a problem hiding this comment.
Don't we want to use framework.Logf here like we do below?
There was a problem hiding this comment.
Fatalf comes with an embedded panic. I will revert to use the framework logging and will panic in the line below
e2etests/pkg/k8s/pods.go
Outdated
|
|
||
| const labelSelector = "app=frr-k8s" | ||
|
|
||
| // SpeakerPods returns the set of pods running the speakers. |
e2etests/pkg/k8s/pods.go
Outdated
Comment on lines
27
to
32
| speakerPods := make([]*corev1.Pod, 0) | ||
| for _, item := range pods.Items { | ||
| i := item | ||
| speakerPods = append(speakerPods, &i) | ||
| } | ||
| return speakerPods, nil |
e2etests/pkg/dump/k8s.go
Outdated
| } | ||
|
|
||
| func K8sInfo(testName string, reporter *k8sreporter.KubernetesReporter) { | ||
| reporter.Dump(10*time.Minute, testName) |
There was a problem hiding this comment.
can you please pass the 10 minutes as a const for clarity?
we named this as LogsExtractDuration on the cnf-tests.
We dump both the content of FRR and the k8s informations. Signed-off-by: Federico Paolinelli <[email protected]>
We want to be able to triage why a test failed, so we dump whenever a failure happens. Signed-off-by: Federico Paolinelli <[email protected]>
Signed-off-by: Federico Paolinelli <[email protected]>
Signed-off-by: Federico Paolinelli <[email protected]>
Signed-off-by: Federico Paolinelli <[email protected]>
|
lgtm. I validated the reports locally on my end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dump relevant information when a test fails.