Add a test plan document #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oribon
reviewed
Jul 5, 2023
There was a problem hiding this comment.
should we add something about configuration breaking the node, blocking accepting pod/svc cidrs?
| - One configuration for the router prefixes, and the other for advertising the prefixes (some) | ||
| - One configuration where we override the announcement list with all | ||
| - One configuration where we override the receiving list with all | ||
|
|
There was a problem hiding this comment.
do we have conflicting config scenarios to handle here?
There was a problem hiding this comment.
At the moment, the only conflict that might happen is for the base entities, such as having different routers asns for the same VRF or different neighbors with the same IP and different asn.
|
|
||
| - Editing the configuration works | ||
| - Deleting a given configuration works | ||
|
|
|
I added a premise about this not being comprehensive and the expectation that each new feature will cover with tests. |
Signed-off-by: Federico Paolinelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.