Build and push the image from CI #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dumping to avoid rogue images we don't know the version of. Signed-off-by: Federico Paolinelli <[email protected]>
liornoy
reviewed
Jul 4, 2023
.github/workflows/publish.yaml
Outdated
| context: . | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| file: ${{matrix.image}}/Dockerfile |
There was a problem hiding this comment.
I don't think we define the matrix here like we do in metallb
Dockerfile
Outdated
| -ldflags "-X 'frr-k8s/internal/version.gitCommit=${GIT_COMMIT}' -X 'frr-k8s/metallb/internal/version.gitBranch=${GIT_BRANCH}'" \ | ||
| frr-tools/metrics/exporter.go \ | ||
| && \ | ||
| # build speaker |
This includes adding the GIT_COMMIT / GIT_BRANCH, ARCH and VARIANT. FRR-K8s must run on the same architectures as metallb. Signed-off-by: Federico Paolinelli <[email protected]>
Additionally, removing the docker-buildx as we'll rely on the GH action to do cross platform builds. Signed-off-by: Federico Paolinelli <[email protected]>
Adding a workflow that will enable the release of the image on quay. Signed-off-by: Federico Paolinelli <[email protected]>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces building and pushing to quay from CI