Add support for "Dynamic ASN" #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oribon
force-pushed
the
dynamic_as
branch
2 times, most recently
from
5014502
to
a596472
Compare
fedepaol
reviewed
Sep 9, 2024
| // internal - if the neighbor's ASN is different than the router's the connection is denied. | ||
| // external - if the neighbor's ASN is the same as the router's the connection is denied. | ||
| // ASN and DynamicASN are mutually exclusive and one of them must be specified. | ||
| // +kubebuilder:validation:Enum=internal;external |
There was a problem hiding this comment.
Can we enforce the mutual exclusivity (or -ness) with CEL rules?
https://kubernetes.io/docs/reference/using-api/cel/
There was a problem hiding this comment.
tried for a while, did not go so well 😅 I guess we can tackle it in a different time (applies for password and passwordSecret as well)
| return false | ||
| } | ||
|
|
||
| if asn == "internal" { |
There was a problem hiding this comment.
let's either have a comment saying that all these ifs mean it's external (or wrap in a "isEBGP" helper)
Add the field to support FRR's automatic ASN detection (https://docs.frrouting.org/en/latest/bgp.html#clicmd-neighbor-PEER-remote-as-internal). Dynamic ASN is not an official name of this feature, but should be understandable. Modifying the original ASN field to be IntOrString was considered but left out since IntOrString is actually Int32OrString, and we explicitly need 32 bits (uint32) for the ASN. Signed-off-by: Ori Braunshtein <[email protected]>
Signed-off-by: Ori Braunshtein <[email protected]>
Signed-off-by: Ori Braunshtein <[email protected]>
Signed-off-by: Ori Braunshtein <[email protected]>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
/kind feature
What this PR does / why we need it:
Adds support for FRR's "Dynamic ASN", allowing users to specify whether the peer is ibgp or ebgp without explicitly setting its asn. Leverages https://docs.frrouting.org/en/latest/bgp.html#clicmd-neighbor-PEER-remote-as-internal
Release note: