Support PrefixesWithCommunity #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oribon
force-pushed
the
parse_communities
branch
5 times, most recently
from
5684302
to
a1d12c6
Compare
oribon
changed the title
fedepaol
reviewed
Jul 17, 2023
internal/controller/api_to_config.go
Outdated
| advs[p] = &frr.AdvertisementConfig{Prefix: p, IPFamily: family} | ||
| } | ||
|
|
||
| prefixToCommunities := map[string]sets.Set[string]{} |
| } | ||
| } | ||
| }, | ||
| validate: func(ppV4 []config.Peer, ppV6 []config.Peer, nodes []v1.Node) { |
There was a problem hiding this comment.
can you add
- a test where we have explicit prefixes, only one with community?
- a test where we have large communities
- a test where we have one address with multiple communities
There was a problem hiding this comment.
done, turns out we didn't have the code to support large communities, added a new commit (copy from MetalLB)
oribon
force-pushed
the
parse_communities
branch
4 times, most recently
from
35126e5
to
e9e24bb
Compare
Copy of the relevant parts from MetalLB Signed-off-by: Ori Braunshtein <[email protected]>
Signed-off-by: Ori Braunshtein <[email protected]>
Signed-off-by: Ori Braunshtein <[email protected]>
oribon
force-pushed
the
parse_communities
branch
from
e9e24bb
to
0715412
Compare
fedepaol
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support parsing community prefixes