Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't treat the non existing secret as a special error #53

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Don't treat the non existing secret as a special error #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions internal/controller/frrconfiguration_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ package controller

import (
"context"
"errors"
"fmt"

corev1 "k8s.io/api/core/v1"
Expand Down Expand Up @@ -97,11 +96,6 @@ func (r *FRRConfigurationReconciler) Reconcile(ctx context.Context, req ctrl.Req
}

config, err := apiToFRR(cfgs, secrets)
secretNotFound := SecretNotFoundError{}
if errors.As(err, &secretNotFound) { // This might be a receiving order issue so we need to return the error and retry
level.Error(r.Logger).Log("controller", "FRRConfigurationReconciler", "failed to apply the config", req.NamespacedName.String(), "secret not found", err)
return ctrl.Result{}, err
}
if err != nil {
updateErrors.Inc()
configStale.Set(1)
Expand Down