-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thin categories, prosets as categories, and poset/toset/lattice #4248
base: develop
Are you sure you want to change the base?
Conversation
@@ -215070,8 +215081,8 @@ an empty base set ( ~ str0 ) and any relation partially orders an empty | |||
YHYCXFCXMYKVGYHXMFUJYLXIVHYIXFCXMFVIVOVJVKVLCDEKUAVMXHXJKWIXGFFHUOLVPVNVQ | |||
VRVSNWKXHWMXJKWIWJXGBXFCFBXFVHWPFUBOVTWAWBWLXIKBXFCFOWCWFWDWEWG $. | |||
|
|||
$( Domain of the least upper bound function of a poset. (Contributed by | |||
NM, 6-Sep-2018.) $) | |||
$( Domain of the least upper bound function of a set. (Contributed by NM, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? "Poset" is good, here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition doesn’t mention anything about poset. In fact for a poset, there is at most one glb/lub for any subset, proved somewhere in dual iirc. So the uniqueness is unnecessary for a poset. See my eldm2 theorems. I think this theorem works for any sets instead of just posets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The role of comments is not to strictly paraphrase the formal statement (the formal statement suffices for that), but to convey the idea of the statement. "Least upper bound" needs at least some kind of order relation to make sense, even if the encoding in set.mm allows some "junk theorems", so "poset" is good here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that some order relation must be there for the theorem to be meaningful. But does it have to be a partial order? I suppose a preorder should suffice. The difference is that a preorder could have multiple LUBs/GLBs so existence does not guarantee uniqueness.
I understand that people usually reference GLB/LUB in posets but we could be more creative here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I wrote "some kind of order relation". Anyway, I think "poset" is good enough, and then people are free to wonder what happens under weaker hypotheses.
$d x y B $. $d x y X $. $d y Y $. $d x y .<_ $. | ||
tleile.b $e |- B = ( Base ` K ) $. | ||
tleile.l $e |- .<_ = ( le ` K ) $. | ||
$( In a Toset, two elements must compare. (Contributed by Thierry Arnoux, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$( In a Toset, two elements must compare. (Contributed by Thierry Arnoux, | |
$( In a Toset, any two elements are comparable. (Contributed by Thierry Arnoux, |
$( In a Toset, less-than is equivalent to not inverse "less than or equal | ||
to" see ~ pltnle . (Contributed by Thierry Arnoux, 11-Feb-2018.) $) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$( In a Toset, less-than is equivalent to not inverse "less than or equal | |
to" see ~ pltnle . (Contributed by Thierry Arnoux, 11-Feb-2018.) $) | |
$( In a Toset, "less than" is equivalent to the negation of the converse of | |
"less than or equal to", see ~ pltnle . (Contributed by Thierry Arnoux, | |
11-Feb-2018.) $) |
$( Lattice join is idempotent. (Contributed by NM, 8-Oct-2011.) $) | ||
latjidm.b $e |- B = ( Base ` K ) $. | ||
latjidm.j $e |- .\/ = ( join ` K ) $. | ||
$( Lattice join is idempotent. ( ~ unidm analog.) See ~ posjidm for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$( Lattice join is idempotent. ( ~ unidm analog.) See ~ posjidm for a | |
$( Lattice join is idempotent. Analogue of ~ unidm analog. See ~ posjidm for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same below. Also, remove the "stronger statement" sentence here and below, and do another PR to move those statements from your mathbox to Main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could potentially do that but the dependency chain is quite long… Moving those might take a while. Maybe revise it to “see also ~ xxx “ before posjidm and posmidm moved to main?
Also, I think some of the theorems indirectly referenced by these two might depend on dual so #4253 should be handled first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot look at the details. In short: you can make comments in your mathbox referencing Main, but the opposite is less common. There are many such examples in contributors' mathboxes.
@@ -217781,12 +217825,13 @@ net proof size (existence part)? $) | |||
${ | |||
$d I x y $. $d C x y $. $d G x y $. $d L x y $. $d U x y $. | |||
$d F x y $. $d X x y $. | |||
mreclat.i $e |- I = ( toInc ` C ) $. | |||
mreclatBAD.i $e |- I = ( toInc ` C ) $. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot make that kind of changes in the main part of set.mm.
If you have proposals for better alternatives, first put them in your mathbox where you can say in the comment there that it is a better alternative, but do not modify the main part. Then, you can propose in an issue to move these to Main or to make other adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have good proposals. The original theorem is self-referenced BAD. The sole reason I renamed this is that I wanted to prove the good version but couldn’t resolve the name clash. This is just temporary before I move the good version to main.
If renaming a main theorem is an absolute no, I can revert the change and rename mine as GOOD instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The database and website are not targeted only at contributors. Imagine a reader who runs into the page for mreclatBAD
. That does not give a good image of the website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree with you. The bad news, is that, it is already there: https://us.metamath.org/mpeuni/mreclatBAD.html
I am trying to fix it but first I need to polish the fixed one in my Mathbox.
Anyways I will revert the change and rename mine as GOOD. Does that sound okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, there are more than one “BAD” theorems in main…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that it's just a hypothesis, I'm fine with either renaming this hypothesis BAD or the other hypothesis GOOD
Probably renaming the other hypothesis GOOD would be the option, then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to relabel the version in the mathbox, and to not have "BAD" in the main part.
Out of town now so could not edit before I come back… |
Let's try and merge it soon. Do not add new theorems or ideas, and only fix open conversations and address existing remarks. |
Won’t be back until 2 weeks later as mentioned in #4248 (comment) |
No worries. Since it's mostly in your mathbox, merge conflicts will be easily resolved. What I meant is that potential new developments should go in a separate PR (also for ease of review), and that new commits in this PR should be only to address existing comments. |
This contains changes in #4242.Probably will wait until the previous PR is merged so that I can fix some merge conflictsNow it is the time.
Added
Fixed
setc2ohom
,latjidm
, andlatmidm
; and others.monepilem
tompbiran3d
and addedmpbiran4d
.Changed