Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thin categories, prosets as categories, and poset/toset/lattice #4248

Open
wants to merge 62 commits into
base: develop
Choose a base branch
from

Conversation

zwang123
Copy link
Contributor

@zwang123 zwang123 commented Sep 26, 2024

This contains changes in #4242.
Probably will wait until the previous PR is merged so that I can fix some merge conflicts
Now it is the time.

Added

  • toslat: A toset is a lattice
  • endmndlem
  • thinccic: In a thin category, two objects are isomorphic iff there are morphisms between them in both directions.
  • postc: The converted category is a poset iff no distinct objects are isomorphic.
  • oppcthin: The opposite of a thin category is thin.
  • subthinc: A subcategory of a thin category is thin.
  • functhinc, fullthinc, thincfth: (full) functors to thin categories; faithful functors from thin categories
  • inpw: Two ways of expressing a collection of subsets
  • posjidm, posmidm: Poset join/meet is idempotent.
  • ipolub/ipoglb: LUB/GLB of inclusion poset.
  • mreclat, mrelatlubALT, and mrelatglbALT: The inclusion poset for a Moore system is a complete lattice
  • topclat, topdlat, and related
  • And lots of other theorems supporting the above

Fixed

  • Description for setc2ohom, latjidm, and latmidm; and others.
  • Rename monepilem to mpbiran3d and added mpbiran4d.

Changed

  • Moved to main
    • biadanid
    • tospos
    • tleile
    • tltnle

set.mm Outdated Show resolved Hide resolved
@zwang123 zwang123 marked this pull request as ready for review September 29, 2024 15:33
@@ -215070,8 +215081,8 @@ an empty base set ( ~ str0 ) and any relation partially orders an empty
YHYCXFCXMYKVGYHXMFUJYLXIVHYIXFCXMFVIVOVJVKVLCDEKUAVMXHXJKWIXGFFHUOLVPVNVQ
VRVSNWKXHWMXJKWIWJXGBXFCFBXFVHWPFUBOVTWAWBWLXIKBXFCFOWCWFWDWEWG $.

$( Domain of the least upper bound function of a poset. (Contributed by
NM, 6-Sep-2018.) $)
$( Domain of the least upper bound function of a set. (Contributed by NM,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? "Poset" is good, here and below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition doesn’t mention anything about poset. In fact for a poset, there is at most one glb/lub for any subset, proved somewhere in dual iirc. So the uniqueness is unnecessary for a poset. See my eldm2 theorems. I think this theorem works for any sets instead of just posets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The role of comments is not to strictly paraphrase the formal statement (the formal statement suffices for that), but to convey the idea of the statement. "Least upper bound" needs at least some kind of order relation to make sense, even if the encoding in set.mm allows some "junk theorems", so "poset" is good here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that some order relation must be there for the theorem to be meaningful. But does it have to be a partial order? I suppose a preorder should suffice. The difference is that a preorder could have multiple LUBs/GLBs so existence does not guarantee uniqueness.

I understand that people usually reference GLB/LUB in posets but we could be more creative here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I wrote "some kind of order relation". Anyway, I think "poset" is good enough, and then people are free to wonder what happens under weaker hypotheses.

$d x y B $. $d x y X $. $d y Y $. $d x y .<_ $.
tleile.b $e |- B = ( Base ` K ) $.
tleile.l $e |- .<_ = ( le ` K ) $.
$( In a Toset, two elements must compare. (Contributed by Thierry Arnoux,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$( In a Toset, two elements must compare. (Contributed by Thierry Arnoux,
$( In a Toset, any two elements are comparable. (Contributed by Thierry Arnoux,

Comment on lines +215945 to +215946
$( In a Toset, less-than is equivalent to not inverse "less than or equal
to" see ~ pltnle . (Contributed by Thierry Arnoux, 11-Feb-2018.) $)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$( In a Toset, less-than is equivalent to not inverse "less than or equal
to" see ~ pltnle . (Contributed by Thierry Arnoux, 11-Feb-2018.) $)
$( In a Toset, "less than" is equivalent to the negation of the converse of
"less than or equal to", see ~ pltnle . (Contributed by Thierry Arnoux,
11-Feb-2018.) $)

$( Lattice join is idempotent. (Contributed by NM, 8-Oct-2011.) $)
latjidm.b $e |- B = ( Base ` K ) $.
latjidm.j $e |- .\/ = ( join ` K ) $.
$( Lattice join is idempotent. ( ~ unidm analog.) See ~ posjidm for a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$( Lattice join is idempotent. ( ~ unidm analog.) See ~ posjidm for a
$( Lattice join is idempotent. Analogue of ~ unidm analog. See ~ posjidm for a

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same below. Also, remove the "stronger statement" sentence here and below, and do another PR to move those statements from your mathbox to Main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could potentially do that but the dependency chain is quite long… Moving those might take a while. Maybe revise it to “see also ~ xxx “ before posjidm and posmidm moved to main?

Also, I think some of the theorems indirectly referenced by these two might depend on dual so #4253 should be handled first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot look at the details. In short: you can make comments in your mathbox referencing Main, but the opposite is less common. There are many such examples in contributors' mathboxes.

@@ -217781,12 +217825,13 @@ net proof size (existence part)? $)
${
$d I x y $. $d C x y $. $d G x y $. $d L x y $. $d U x y $.
$d F x y $. $d X x y $.
mreclat.i $e |- I = ( toInc ` C ) $.
mreclatBAD.i $e |- I = ( toInc ` C ) $.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot make that kind of changes in the main part of set.mm.

If you have proposals for better alternatives, first put them in your mathbox where you can say in the comment there that it is a better alternative, but do not modify the main part. Then, you can propose in an issue to move these to Main or to make other adjustments.

Copy link
Contributor Author

@zwang123 zwang123 Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have good proposals. The original theorem is self-referenced BAD. The sole reason I renamed this is that I wanted to prove the good version but couldn’t resolve the name clash. This is just temporary before I move the good version to main.

If renaming a main theorem is an absolute no, I can revert the change and rename mine as GOOD instead.

Copy link
Contributor

@benjub benjub Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The database and website are not targeted only at contributors. Imagine a reader who runs into the page for mreclatBAD. That does not give a good image of the website.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree with you. The bad news, is that, it is already there: https://us.metamath.org/mpeuni/mreclatBAD.html

I am trying to fix it but first I need to polish the fixed one in my Mathbox.

Anyways I will revert the change and rename mine as GOOD. Does that sound okay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, there are more than one “BAD” theorems in main…

Copy link
Contributor

@icecream17 icecream17 Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it's just a hypothesis, I'm fine with either renaming this hypothesis BAD or the other hypothesis GOOD
Probably renaming the other hypothesis GOOD would be the option, then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to relabel the version in the mathbox, and to not have "BAD" in the main part.

@zwang123
Copy link
Contributor Author

zwang123 commented Oct 2, 2024

Out of town now so could not edit before I come back…

@benjub
Copy link
Contributor

benjub commented Oct 4, 2024

Let's try and merge it soon. Do not add new theorems or ideas, and only fix open conversations and address existing remarks.

@zwang123
Copy link
Contributor Author

zwang123 commented Oct 5, 2024

Let's try and merge it soon. Do not add new theorems or ideas, and only fix open conversations and address existing remarks.

Won’t be back until 2 weeks later as mentioned in #4248 (comment)
Looks like those open conversations are easy fixes but it’s hard to do it on my end…

@benjub
Copy link
Contributor

benjub commented Oct 5, 2024

Let's try and merge it soon. Do not add new theorems or ideas, and only fix open conversations and address existing remarks.

Won’t be back until 2 weeks later as mentioned in #4248 (comment) Looks like those open conversations are easy fixes but it’s hard to do it on my end…

No worries. Since it's mostly in your mathbox, merge conflicts will be easily resolved. What I meant is that potential new developments should go in a separate PR (also for ease of review), and that new commits in this PR should be only to address existing comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants