Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include bibliography section in A1 and A2 for standalone document #257

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

manuelfuenmayor
Copy link
Contributor

Fixes #252

In this PR, I added the Bibliography section to Appendices 1 and 4 to fix the "references not found" issue.
And, in order to avoid conflict with the complete Brochure, I edited the lines attribute of the corresponding include:: directives to exclude the added bibliographies.

This change is applied to v3.01 only. Let me know if you agree with this solution, to do the same in the rest of the versions.

@ronaldtse
Copy link
Contributor

@manuelfuenmayor I've made my changes and this can merge now. Can you please make the same changes to 1.08 and 2.01 for consistency reasons? Thanks.

@ronaldtse
Copy link
Contributor

@manuelfuenmayor there is an error in a formula?

[info]: Compiling /home/runner/work/bipm-si-brochure/bipm-si-brochure/sources/mep-metre-definition-en.adoc ...
...
Maths: Malformed MathML: [plurimath] Error: Failed to parse the following formula with type `asciimath`.
[plurimath] Please first manually validate the formula.
[plurimath] If this is a bug, please report the formula at our issue tracker at:
[plurimath] https://github.com/plurimath/plurimath/issues
---- FORMULA BEGIN ----
{:(ii(E)_1, =, ii(A)_1 cos[ii(varphi)_1]),(ii(E)_2, =, ii(A)_2 cos[ii(varphi)_2]):}}  rarr I = langle (ii(E)_1 + ii(E)_2)^2 rangle_t = {ii(A)_1^2}/2 + {ii(A)_2^2}/2 + ii(A)_1 ii(A)_2 cos[ii(varphi)_1 - ii(varphi)_2]
---- FORMULA END ----

@manuelfuenmayor
Copy link
Contributor Author

manuelfuenmayor commented Dec 18, 2024

@manuelfuenmayor there is an error in a formula?

@ronaldtse the formula renders correctly on my side:

complex-formula
(The MathML code is a little large, so I leave it as text file: complex-formula.txt)

But when I test it on plurimath.org, it doesn't render.

Formula code:

[stem]
++++
{:(ii(E)_1, =, ii(A)_1 cos[ii(varphi)_1]),(ii(E)_2, =, ii(A)_2 cos[ii(varphi)_2]):}}  rarr I = langle (ii(E)_1 + ii(E)_2)^2 rangle_t = {ii(A)_1^2}/2 + {ii(A)_2^2}/2 + ii(A)_1 ii(A)_2 cos[ii(varphi)_1 - ii(varphi)_2]
++++

Perhaps @suleman-uzair can help us in this case?

@manuelfuenmayor
Copy link
Contributor Author

@manuelfuenmayor there is an error in a formula?

I've raised a ticket about it.

Merging.

@manuelfuenmayor manuelfuenmayor merged commit e1880fd into main Dec 18, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(URGENT) Fix "references not found" for SI Brochure A4
2 participants