ft(export-unsigned-transaction): Export instructions to merge into bigger transaction #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: As I can see from your metaplex web, when we take an action like selling NFT, we need to sign only one times to process createVault, addTokensToVault, activeVault, ... Our code may go out-of-date if not use from npm
Solution: Should we return a transactionBatch to use in a bigger transaction (sign one times) instead of calling these actions (actions.createExternalPriceAccount, actions.createVault...) and request users to approve for each transaction
If you OK, I will modify more function and find some pattern to reduce duplicate code check
isUninitialized