-
Notifications
You must be signed in to change notification settings - Fork 183
feat: ✨ plugins: Transition from Bundlr to Irys storage driver #533
feat: ✨ plugins: Transition from Bundlr to Irys storage driver #533
Conversation
Transitions from a deprecated Bundlr js sdk version to the latest Irys SDK
🦋 Changeset detectedLatest commit: 496b73b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We're also experiencing the issue, so this would be great 👍 |
Hey @YvesCandel , |
what is the fixed git repo URL supposed to be? I'm also getting this issue and when I did a |
i've tried |
@justinkchen maybe uninstall/remove @metaplex-foundation/js (or whatever depends on it) and then reinstall it? that should remove it and re-add it to the lockfile |
@JesseTheRobot that did it! thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that! I no longer have the rights to trigger CI but if it passes I think it's okay to merge. Note that here it's okay replace the Bundlr package (as opposed to in Umi) because here everything is bundled together so we want to avoid adding too many dependencies.
facing the same issues, uninstall/install like @JesseTheRobot mentioned solves it for now |
hey @lorisleiva , apologies for the inactivity on this PR as well. |
Thanks! Cc @febo would you mind just pressing the button to approve CI? |
I'm not sure what I need to do here to fix the linting CI |
|
I already ran that locally and it produced 0 changes - it looks like the pipeline errored trying to push to my branch, and the actual lint:fix ran without producing any changes. |
@lorisleiva is there anything else I need to do here? |
Hmm if it's just a linting issue I'm happy to merge it as-is. The main workflow will automatically create a fix commit when merged. I'm not at Metaplex anymore so I don't have the rights to merge but maybe @febo can do the honours? |
Context: Bundlr rebranded as Irys earlier today, and the GH org rename caused issues with users due to the AVSC git dependency the old version of the js-client being used.
To fix this, this PR transitions from a deprecated Bundlr js sdk version to the latest Irys SDK, and includes all relevant changes/renaming, including README & test changes.
Note: I wasn't able to figure out how to get most test cases to pass, I assume there's a testing endpoint I need to set up - but all the tests I was able to get working pass.