Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base set of labels #38

Closed
wants to merge 2 commits into from
Closed

Conversation

SemenchenkoVitaliy
Copy link
Member

Info: #37.

labels.json Outdated Show resolved Hide resolved
labels.json Outdated
"description": "Issues that will not be fixed, e.g. due to backwards compatibility concerns."
},
{
"name": "work in progress",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already in progress, I'd prefer to only have one label for this purpose.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to have in progress to show that issue\PR is being worked on, we have Drafts for WIP: PR, that are still not finished.

labels.json Outdated Show resolved Hide resolved
labels.json Outdated Show resolved Hide resolved
labels.json Outdated Show resolved Hide resolved
labels.json Outdated Show resolved Hide resolved
labels.json Outdated Show resolved Hide resolved
labels.json Outdated Show resolved Hide resolved
labels.json Outdated Show resolved Hide resolved
labels.json Outdated Show resolved Hide resolved
labels.json Outdated Show resolved Hide resolved
labels.json Outdated Show resolved Hide resolved
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Though I still think that triage-* aren't needed.

labels.json Outdated
{
"name": "in progress",
"color": "d93f0b",
"description": "Issues and PRs that are still in progress."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Issues and PRs that are still in progress."
"description": "Issues and PRs that are in progress."

@SemenchenkoVitaliy
Copy link
Member Author

ping @nechaido @belochub.

@belochub belochub force-pushed the add-labels-base-set branch from 8cedf9a to 61e442f Compare June 27, 2019 11:32
@belochub
Copy link
Member

belochub commented Jul 3, 2019

@tshemsedinov can you land this, please?

Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few fixes

labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
labels/make-preview.js Outdated Show resolved Hide resolved
@belochub belochub force-pushed the add-labels-base-set branch from fa38d19 to 3a39e21 Compare July 5, 2019 14:21
tshemsedinov pushed a commit that referenced this pull request Jul 5, 2019
tshemsedinov pushed a commit that referenced this pull request Jul 5, 2019
@tshemsedinov
Copy link
Member

Landed in cc15523 and c87a3ea

@tshemsedinov tshemsedinov deleted the add-labels-base-set branch July 5, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants