Fix retrieval of a missing l10n for action

PR-URL: #403
metarhia · Apr 8, 2019 · 4ba170b · 4ba170b
1 parent 383754f
commit 4ba170b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/lib/provider.js b/lib/provider.js
@@ -721,6 +721,7 @@ class StorageProvider {
           `No ${langTag} localization data for ${category}.${action} action`
         )
       );
+      return;
     }
     process.nextTick(callback, null, l10n);
   }

diff --git a/test/fixtures/resources/Category.AnotherAction.action b/test/fixtures/resources/Category.AnotherAction.action
@@ -0,0 +1,4 @@
+Action({
+  Params: {},
+  Execute: async () => {},
+})
diff --git a/test/ms.resources.js b/test/ms.resources.js
@@ -68,7 +68,7 @@ metatests.test('StorageProvider supports localization methods', async test => {
 
   const provider = new StorageProvider({});
   provider.open({ schema }, () => {
-    test.plan(23);
+    test.plan(24);
     provider.getCommonL10n('en', (err, l10n) => {
       test.error(err);
       test.strictSame(l10n, '{"Id":"Identifier"}');
@@ -142,6 +142,15 @@ metatests.test('StorageProvider supports localization methods', async test => {
         )
       );
     });
+    provider.getActionL10n('uk', 'Category', 'AnotherAction', err => {
+      test.isError(
+        err,
+        new GSError(
+          errorCodes.NOT_FOUND,
+          `No uk localization data for Category.AnotherAction action`
+        )
+      );
+    });
 
     provider.getCategoryL10n('uk', 'Category', err => {
       test.isError(
-Original file line number
+Diff line change
@@ Expand Up / @@ -721,6 +721,7 @@ class StorageProvider { @@
               `No ${langTag} localization data for ${category}.${action} action`
             )
           );
+          return;
         }
         process.nextTick(callback, null, l10n);
       }
@@ Expand Down @@