Add linter config for schemas #415
Conversation
.eslintignore
Outdated
| @@ -0,0 +1,8 @@ | |||
| data/ | |||
There was a problem hiding this comment.
I think at this point it would be easier to specify only the files that should be linted, not the files that must be ignored:
| data/ | |
| * | |
| !*.js | |
| !*.action | |
| !*.category | |
| !*.domains | |
| !*.form |
There was a problem hiding this comment.
Eslint will lint only .js files, if there is no extensions specified using --ext. So lint script will look like this:
eslint --ext .js,.action,.category,.domains,.form . && prettier -c \"**/*\"
package.json
Outdated
| @@ -34,8 +34,8 @@ | |||
| ], | |||
| "scripts": { | |||
| "test": "npm run lint && metatests test/", | |||
| "lint": "eslint . --ignore-path .gitignore && prettier -c \"**/*.js\" \"**/*.json\" \"**/*.md\" \".*rc\" \"**/*.yml\"", | |||
| "fmt": "prettier --write \"**/*.js\" \"**/*.json\" \"**/*.md\" \".*rc\" \"**/*.yml\"", | |||
| "lint": "eslint \"**/*\" && prettier -c \"*\"", | |||
There was a problem hiding this comment.
| "lint": "eslint \"**/*\" && prettier -c \"*\"", | |
| "lint": "eslint \"**/*\" && prettier -c \"**/*\"", |
package.json
Outdated
| "lint": "eslint . --ignore-path .gitignore && prettier -c \"**/*.js\" \"**/*.json\" \"**/*.md\" \".*rc\" \"**/*.yml\"", | ||
| "fmt": "prettier --write \"**/*.js\" \"**/*.json\" \"**/*.md\" \".*rc\" \"**/*.yml\"", | ||
| "lint": "eslint \"**/*\" && prettier -c \"*\"", | ||
| "fmt": "eslint --fix \"**/*\" && prettier --write \"*\"", |
There was a problem hiding this comment.
| "fmt": "eslint --fix \"**/*\" && prettier --write \"*\"", | |
| "fmt": "eslint --fix \"**/*\" && prettier --write \"**/*\"", |
.prettierignore
Outdated
| @@ -1,2 +1,7 @@ | |||
| data | |||
| dist | |||
| data/ | |||
There was a problem hiding this comment.
I have bumped into a strange behavior of .prettierignore.
I have tried this, and it lints only gs.js file and does not go deeper.
*
!*.js
Then I have tried this, and nothing have changed.
*
!**/*.js
There was a problem hiding this comment.
The same with .eslintignore.
There was a problem hiding this comment.
@o-rumiantsev, right, I forgot to add the !*/ rule after the *.
o-rumiantsev
force-pushed
the
add-linter-config-for-schemas
branch
2 times, most recently
from
dd48755 to
51e7b98
Compare
o-rumiantsev
force-pushed
the
add-linter-config-for-schemas
branch
from
51e7b98 to
081636e
Compare
.prettierignore
Outdated
| !*.action | ||
| !*.category | ||
| !*.domains | ||
| !*.form |
There was a problem hiding this comment.
| !*.form | |
| !*.form | |
| !*.application |
?
schemas/system/Locking.category
Outdated
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable no-unused-vars, no-undef, handle-callback-err */ | |||
There was a problem hiding this comment.
Could you clarify the need for these?
If they were meant to handle the callback of Lock action then I'd prefer to just either put () => {} in there or comment out the arguments if they are needed for some reason.
schemas/system/Permission.category
Outdated
| CheckBound: Validate(record => true) | ||
| }) | ||
| /* eslint-disable no-unused-vars */ | ||
| CheckBound: Validate(record => true), |
schemas/system/SystemUser.category
Outdated
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable no-unused-vars, no-undef */ | |||
There was a problem hiding this comment.
Ditto.
Maybe just put SignUp: Action((/* data, callback */) => {?
| @@ -0,0 +1,27 @@ | |||
| globals: | |||
There was a problem hiding this comment.
These look the same as those in schemas/.eslintrc.yml, could we perhaps put them in a common config file (i.e. schemas-eslint-config.js) that would be extendsed in schemas/.eslintrc.yml and test/fixtures/.eslintrc.yml?
No description provided.