Add context support #427
Open
Add context support #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-rumiantsev
force-pushed
the
add-context-support
branch
3 times, most recently
from
5710c76
to
475a40a
Compare
o-rumiantsev
force-pushed
the
add-context-support
branch
from
475a40a
to
817820e
Compare
lundibundi
reviewed
May 30, 2019
| context: 'context', | ||
| }; | ||
|
|
||
| const dataTypes = ['domain', 'category', 'context']; |
There was a problem hiding this comment.
Suggested change
| const dataTypes = ['domain', 'category', 'context']; | |
| const dataTypes = Object.keys(propToTypes); |
o-rumiantsev
force-pushed
the
add-context-support
branch
from
817820e
to
5189dce
Compare
o-rumiantsev
force-pushed
the
add-context-support
branch
from
5189dce
to
34f6a54
Compare
nechaido
reviewed
Jun 14, 2019
| const { options, config } = require('../lib/metaschema-config/config'); | ||
|
|
||
| const { MetaschemaError, SchemaValidationError } = metaschema.errors; | ||
|
|
There was a problem hiding this comment.
Please add a positive test, to ensure that it is possible to use context args in actions.
lib/metaschema-config/context.js
Outdated
|
|
||
| const addContext = (context, ms) => { | ||
| const errors = []; | ||
| const duplicateContext = ms.context.size > 0; |
There was a problem hiding this comment.
IMHO this is not a suitable variable name. Maybe something like isContextDuplicate or isContextExist.
lib/metaschema-config/utils.js
Outdated
| @@ -6,34 +6,23 @@ const { | |||
| extractDecorator, | |||
| } = require('metaschema'); | |||
|
|
|||
| const propToTypes = { | |||
There was a problem hiding this comment.
Suggested change
| const propToTypes = { |
WDYT?
lib/metaschema-config/utils.js
Outdated
| context: 'context', | ||
| }; | ||
|
|
||
| const dataTypes = Object.keys(propToTypes); |
There was a problem hiding this comment.
Suggested change
| const dataTypes = Object.keys(propToTypes); | |
| const dataTypes = ['domain', 'category', 'context']; |
lib/metaschema-config/utils.js
Outdated
| for (const type of dataTypes) { | ||
| const value = field[type]; | ||
| if (value) { | ||
| const def = ms[propToTypes[type]].get(value); |
There was a problem hiding this comment.
type === 'domain' ? 'domains' : type;
const def = ms[type].get(value);
lib/metaschema-config/utils.js
Outdated
| }; | ||
|
|
||
| const dataTypes = Object.keys(propToTypes); | ||
| const getDefinition = { |
There was a problem hiding this comment.
Suggested change
| const getDefinition = { | |
| const getDefinition = type => schema => type === 'category' ? schema.definition : schema; |
There was a problem hiding this comment.
Think, it is better to write like this:
const getDefinition = (type, schema) => type === 'category' ? schema.definition : schema
lib/metaschema-config/utils.js
Outdated
| new SchemaValidationError('unresolved', `${source}.${key}`, info) | ||
| ); | ||
| } else { | ||
| field.definition = getDefinition[type](def); |
There was a problem hiding this comment.
Suggested change
| field.definition = getDefinition[type](def); | |
| field.definition = getDefinition(type)(def); |
o-rumiantsev
force-pushed
the
add-context-support
branch
from
f4907a4
to
73fd562
Compare
o-rumiantsev
force-pushed
the
add-context-support
branch
from
73fd562
to
a09ffac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.