Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rustc to 1.65 #245

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Bump rustc to 1.65 #245

merged 1 commit into from
Oct 10, 2023

Conversation

PicoCentauri
Copy link
Contributor

@PicoCentauri PicoCentauri commented Oct 10, 2023


📚 Documentation preview 📚: https://rascaline--245.org.readthedocs.build/en/245/

@PicoCentauri PicoCentauri requested a review from Luthaf October 10, 2023 10:09
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping wheels.zip and using pip to install the file matching your system

@Luthaf
Copy link
Member

Luthaf commented Oct 10, 2023

This is a bit weird. CI in #235 is failing due to regex, but we should not have regex anywhere in our dependency tree. I'll look a bit more into this!

@PicoCentauri
Copy link
Contributor Author

cargo tree told me it seems to live in a dev dependency of criterion -> regex -> regex-automata

[dev-dependencies]
├── criterion v0.4.0
│   ├── anes v0.1.6
│   ├── atty v0.2.14
│   │   └── libc v0.2.148
│   ├── cast v0.3.0
│   ├── ciborium v0.2.1
│   │   ├── ciborium-io v0.2.1
│   │   ├── ciborium-ll v0.2.1
│   │   │   ├── ciborium-io v0.2.1
│   │   │   └── half v1.8.2
│   │   └── serde v1.0.188 (*)
│   ├── clap v3.2.25
│   │   ├── bitflags v1.3.2
│   │   ├── clap_lex v0.2.4
│   │   │   └── os_str_bytes v6.5.1
│   │   ├── indexmap v1.9.3 (*)
│   │   └── textwrap v0.16.0
│   ├── criterion-plot v0.5.0
│   │   ├── cast v0.3.0
│   │   └── itertools v0.10.5
│   │       └── either v1.9.0
│   ├── itertools v0.10.5 (*)
│   ├── lazy_static v1.4.0
│   ├── num-traits v0.2.16 (*)
│   ├── oorandom v11.1.3
│   ├── plotters v0.3.5
│   │   ├── num-traits v0.2.16 (*)
│   │   ├── plotters-backend v0.3.5
│   │   └── plotters-svg v0.3.5
│   │       └── plotters-backend v0.3.5
│   ├── rayon v1.7.0 (*)
│   ├── regex v1.9.5
│   │   ├── regex-automata v0.3.8
│   │   │   └── regex-syntax v0.7.5
│   │   └── regex-syntax v0.7.5
│   ├── serde v1.0.188 (*)
│   ├── serde_derive v1.0.188 (proc-macro) (*)
│   ├── serde_json v1.0.107 (*)
│   ├── tinytemplate v1.2.1
│   │   ├── serde v1.0.188 (*)
│   │   └── serde_json v1.0.107 (*)
│   └── walkdir v2.4.0
│       └── same-file v1.0.6

.readthedocs.yml Outdated Show resolved Hide resolved
@Luthaf
Copy link
Member

Luthaf commented Oct 10, 2023

Ok, it seems painful to remove regex from criterion, so we can bump!

@PicoCentauri
Copy link
Contributor Author

Bump it is!

Co-authored-by: Guillaume Fraux <[email protected]>
@PicoCentauri PicoCentauri merged commit e8265ec into master Oct 10, 2023
23 of 24 checks passed
@PicoCentauri PicoCentauri deleted the bump_rustc branch October 10, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants